@lygstate, we got to review this for 1.8. I merged with the latest changes in develop and I am testing.
Even your first commit did not include util.envSet and util.envGetValue in util.ts. First I thought that I merged something wrong.
I did some changes on my side to unblock testing but if you had anything special in mind for envSet and engGetValue please push an update.

Also fixes the output encoding.

@lygstate, the output encoding fix is in util.parseVersion? Do we have a GitHub issue created for that?

Also fixes the output encoding.

@lygstate, the output encoding fix is in util.parseVersion? Do we have a GitHub issue created for that?

I split the fix of encoding problem in separate PR #1985

@lygstate, if you want you can push an update. I tested this and I sign off with 2 comments:

• revert the vcvars file name change as it was before this PR, for arm32/arm64
• figure out what you wanted with util.envGetValue and util.envSet. For now, when testing, I simply used var.get and var.set.
  If you won't have the chance, I'll push an update or start a new PR from my own branch (derived from yours) later tomorrow.

@lygstate, I noticed that you mentioned that this PR depends on #1763. We may not be able to test thoroughly the env var consistency PR before we release 1.8. It was a large PR with interesting scenarios to cover. When I tested this msvc PR it worked fine. Let me know if I overlooked something. Do you think this msvc PR can work without the env var consistency one?

Another question, can you describe the encoding problem? Just to make sure I properly test that one too and I don't miss something. What was happening.

@lygstate, for an example of what I needed to change in order to have successful testing see branch dev/andris/cmake-tools/fromPR1955.

@lygstate Is it necessary to add 'Platform' to the list of MSVC variables to make your PR succeed? We are experiencing a regression in building some of our projects and this blocks the release of 1.8.0. @elahehrashedi has PR #2056 out where she removes this from the list and it fixes our problem. Do you see any problem with us removing it?